[Mesa-dev] [PATCH] intel: Fix yet-another-bug in intel_texsubimage_tiled_memcpy

[Eric Anholt]

Chad Versace <chad.versace at linux.intel.com> writes:

> The most recent commit that touched this function,
>
>     commit 88836663ac3baaf156e84584674aac7dcbfc7e95
>     Author: Chad Versace <chad.versace at linux.intel.com>
>     Date:   Wed Sep 26 11:05:12 2012 -0700
>
>         intel: Fix segfault in intel_texsubimage_tiled_memcpy
>
> did fix the segfault, but introduced yet another bug. From Anholt: """You
> need to still test format/type, because that's the incoming format (e.g.
> GL_RGBA/GL_FLOAT) that you're trying to memcpy."""
>
> This patch re-introduces the checks on the incoming format and type.

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20120927/5f6c1ef1/attachment-0001.pgp>