[Mesa-dev] [origin/9.0] Haiku build breakage due to 8f7990c5f2 -- lex changes - resolved

[kallisti5]

On 2012-09-30 12:49 pm, Matt Turner wrote:
> On Sun, Sep 30, 2012 at 10:27 AM, kallisti5 <kallisti5 at unixzen.com> 
> wrote:
>> On 2012-09-30 12:16 pm, Kenneth Graunke wrote:
>>>
>>> On 09/30/2012 07:37 AM, kallisti5 wrote:
>>>>
>>>> Good morning,
>>>>
>>>> It seems 8f7990c5f2 has broken the Haiku build...
>>>>
>>>> http://cgit.freedesktop.org/mesa/mesa/commit/?h=9.0&id=8f7990c5f2
>>>>
>>>>
>>>> After 8f7990c5f2 we are getting the following failure:
>>>>
>>>>   Linking build/haiku-x86-debug/glsl/builtin_compiler ...
>>>> build/haiku-x86-debug/glsl/glcpp/glcpp-parse.o: In function 
>>>> `yyparse':
>>>> /Data/mesa/build/haiku-x86-debug/glsl/glcpp/glcpp-parse.c:1779:
>>>> undefined reference to `yylex'
>>>> build/haiku-x86-debug/glsl/glcpp/pp.o: In function 
>>>> `glcpp_preprocess':
>>>> /Data/mesa/src/glsl/glcpp/pp.c:162: undefined reference to
>>>> `glcpp_parser_parse'
>>>> collect2: ld returned 1 exit status
>>>> scons: *** [build/haiku-x86-debug/glsl/builtin_compiler] Error 1
>>>> scons: building terminated because of errors.
>>>>
>>>> Any ideas on the solution?  I'm not big on the lex, bison stuff.
>>>>
>>>>  -- Alex
>>>
>>>
>>> That's weird...you're not using automake?  You need to call bison 
>>> with
>>> the -p "glcpp_parser_" option.  This changes the prefix on all 
>>> functions
>>> from the generic "yy" to "glcpp_parser_" to avoid symbol conflicts.
>>>
>>> Alternatively, I think we could specify it in the .y file via:
>>> %name-prefix glcpp_parser_
>>>
>>> which might be a better idea, since it works independently of the 
>>> build
>>> system.
>>
>>
>> We're using the scons build system :)
>>
>> I checked and don't see any lex.yy.c generated in the tree.
>>
>> -- Alex
>
> Oh, scons.
>
> https://bugs.freedesktop.org/show_bug.cgi?id=54947

I can confirm this is resolved after the following commit:
http://cgit.freedesktop.org/mesa/mesa/commit/?h=9.0&id=e642d61d130b725c0c3efbc87f86a4968311ba2a

The Mesa 9.0 branch now builds under Haiku again.

Thanks!
  -- Alex