[Mesa-dev] [PATCH 4/8] glsl: Don't return a value from check_builtin_array_max_size

Ian Romanick idr at freedesktop.org
Mon Apr 1 11:25:20 PDT 2013


From: Ian Romanick <ian.d.romanick at intel.com>

That last consumer of the return value was changed to not use it by the
previous commit.

Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
---
 src/glsl/ast.h          | 2 +-
 src/glsl/ast_to_hir.cpp | 5 +----
 2 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/src/glsl/ast.h b/src/glsl/ast.h
index 475fb99..41254cc 100644
--- a/src/glsl/ast.h
+++ b/src/glsl/ast.h
@@ -864,7 +864,7 @@ _mesa_ast_array_index_to_hir(void *mem_ctx,
 void
 emit_function(_mesa_glsl_parse_state *state, ir_function *f);
 
-extern bool
+extern void
 check_builtin_array_max_size(const char *name, unsigned size,
                              YYLTYPE loc, struct _mesa_glsl_parse_state *state);
 
diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
index 5980cb0..e9fa4a8 100644
--- a/src/glsl/ast_to_hir.cpp
+++ b/src/glsl/ast_to_hir.cpp
@@ -904,7 +904,7 @@ get_scalar_boolean_operand(exec_list *instructions,
  * If name refers to a builtin array whose maximum allowed size is less than
  * size, report an error and return true.  Otherwise return false.
  */
-bool
+void
 check_builtin_array_max_size(const char *name, unsigned size,
                              YYLTYPE loc, struct _mesa_glsl_parse_state *state)
 {
@@ -918,7 +918,6 @@ check_builtin_array_max_size(const char *name, unsigned size,
       _mesa_glsl_error(&loc, state, "`gl_TexCoord' array size cannot "
                        "be larger than gl_MaxTextureCoords (%u)\n",
                        state->Const.MaxTextureCoords);
-      return true;
    } else if (strcmp("gl_ClipDistance", name) == 0
               && size > state->Const.MaxClipPlanes) {
       /* From section 7.1 (Vertex Shader Special Variables) of the
@@ -933,9 +932,7 @@ check_builtin_array_max_size(const char *name, unsigned size,
       _mesa_glsl_error(&loc, state, "`gl_ClipDistance' array size cannot "
                        "be larger than gl_MaxClipDistances (%u)\n",
                        state->Const.MaxClipPlanes);
-      return true;
    }
-   return false;
 }
 
 /**
-- 
1.8.1.4



More information about the mesa-dev mailing list