[Mesa-dev] [PATCH] register_allocate: Fix the type of best_benefit.

Kenneth Graunke kenneth at whitecape.org
Tue Apr 2 18:58:46 PDT 2013


On 04/02/2013 01:38 PM, Matt Turner wrote:
> ---
>   src/mesa/program/register_allocate.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/src/mesa/program/register_allocate.c b/src/mesa/program/register_allocate.c
> index a9064c3..7d11b73 100644
> --- a/src/mesa/program/register_allocate.c
> +++ b/src/mesa/program/register_allocate.c
> @@ -561,7 +561,7 @@ int
>   ra_get_best_spill_node(struct ra_graph *g)
>   {
>      unsigned int best_node = -1;
> -   unsigned int best_benefit = 0.0;
> +   float best_benefit = 0.0;
>      unsigned int n;
>
>      for (n = 0; n < g->count; n++) {

Yikes.  Good catch...

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>



More information about the mesa-dev mailing list