[Mesa-dev] [PATCH 6/6] i965: Enable ARB_texture_gather on Gen7

[Kenneth Graunke]

On 03/31/2013 04:01 PM, Matt Turner wrote:
> On Sun, Mar 31, 2013 at 2:10 AM, Chris Forbes <chrisf at ijw.co.nz> wrote:
>> Signed-off-by: Chris Forbes <chrisf at ijw.co.nz>
>> ---
>>   src/mesa/drivers/dri/i965/brw_context.c       | 1 +
>>   src/mesa/drivers/dri/intel/intel_extensions.c | 4 ++++
>>   2 files changed, 5 insertions(+)
>>
>> diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/brw_context.c
>> index ceaf325..e8f9c60 100644
>> --- a/src/mesa/drivers/dri/i965/brw_context.c
>> +++ b/src/mesa/drivers/dri/i965/brw_context.c
>> @@ -210,6 +210,7 @@ brwCreateContext(int api,
>>         ctx->Const.MaxColorTextureSamples = 8;
>>         ctx->Const.MaxDepthTextureSamples = 8;
>>         ctx->Const.MaxIntegerSamples = 8;
>> +      ctx->Const.MaxProgramTextureGatherComponents = 4;
>>      }
>>
>>      /* if conformance mode is set, swrast can handle any size AA point */
>> diff --git a/src/mesa/drivers/dri/intel/intel_extensions.c b/src/mesa/drivers/dri/intel/intel_extensions.c
>> index 9efdee4..450c84d 100755
>> --- a/src/mesa/drivers/dri/intel/intel_extensions.c
>> +++ b/src/mesa/drivers/dri/intel/intel_extensions.c
>> @@ -110,6 +110,10 @@ intelInitExtensions(struct gl_context *ctx)
>>         ctx->Extensions.ARB_texture_multisample = true;
>>      }
>>
>> +   if (intel->gen == 7) {
>> +      ctx->Extensions.ARB_texture_gather = true;
>> +   }
>> +
>
> Put this above the intel->gen (>|=)= 6 blocks? Also update GL3.txt :)

Nope, because Chris hasn't implemented it for Sandybridge in this 
series.  It would need MaxProgramTextureGatherComponents = 1 for starts, 
and probably some workarounds...