[Mesa-dev] [PATCH 01/17] i965/vs: Make type of vec4_visitor::vp more generic.

Eric Anholt eric at anholt.net
Mon Apr 8 09:15:11 PDT 2013


Paul Berry <stereotype441 at gmail.com> writes:

> The vec4_visitor functions don't use any VS specific data from
> vec4_visitor::vp.  So rename it to just "p" and change its type from
> struct gl_vertex_program * to struct gl_program *.  This will allow
> the code to be re-used for geometry shaders.

In many other places in the driver, "p" is a brw_compile.  I'd rather
not overload that name.  In a couple other cases where we've had both
the gl_shader_program and the gl_program, the shader_program becomes
"shader_prog" (only about 8 instances in brw_vec4) and gl_program gets
to be just "prog"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130408/8cc40f10/attachment.pgp>


More information about the mesa-dev mailing list