[Mesa-dev] [PATCH 1/2] mesa: Update comments to match newer specs.
Ian Romanick
idr at freedesktop.org
Mon Apr 8 10:38:43 PDT 2013
On 04/08/2013 10:29 AM, Matt Turner wrote:
> Old GL 1.x specs used 'b' but newer specs use 'p'. The line immediately
> above the second hunk also uses 'p'.
Series is
Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
> ---
> src/mesa/main/mtypes.h | 2 +-
> src/mesa/main/texobj.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h
> index 008f68b..3d8f359 100644
> --- a/src/mesa/main/mtypes.h
> +++ b/src/mesa/main/mtypes.h
> @@ -1171,7 +1171,7 @@ struct gl_texture_object
> GLint MaxLevel; /**< max mipmap level, OpenGL 1.2 */
> GLint ImmutableLevels; /**< ES 3.0 / ARB_texture_view */
> GLint _MaxLevel; /**< actual max mipmap level (q in the spec) */
> - GLfloat _MaxLambda; /**< = _MaxLevel - BaseLevel (q - b in spec) */
> + GLfloat _MaxLambda; /**< = _MaxLevel - BaseLevel (q - p in spec) */
> GLint CropRect[4]; /**< GL_OES_draw_texture */
> GLenum Swizzle[4]; /**< GL_EXT_texture_swizzle */
> GLuint _Swizzle; /**< same as Swizzle, but SWIZZLE_* format */
> diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c
> index 66377c8..d0fcb12 100644
> --- a/src/mesa/main/texobj.c
> +++ b/src/mesa/main/texobj.c
> @@ -553,7 +553,7 @@ _mesa_test_texobj_completeness( const struct gl_context *ctx,
> t->_MaxLevel = MIN2(t->_MaxLevel, t->MaxLevel);
> t->_MaxLevel = MIN2(t->_MaxLevel, maxLevels - 1); /* 'q' in the GL spec */
>
> - /* Compute _MaxLambda = q - b (see the 1.2 spec) used during mipmapping */
> + /* Compute _MaxLambda = q - p in the spec used during mipmapping */
> t->_MaxLambda = (GLfloat) (t->_MaxLevel - baseLevel);
>
> if (t->Immutable) {
>
More information about the mesa-dev
mailing list