[Mesa-dev] [PATCH 01/17] i965/vs: Make type of vec4_visitor::vp more generic.

[Eric Anholt]

Paul Berry <stereotype441 at gmail.com> writes:

> On 8 April 2013 09:15, Eric Anholt <eric at anholt.net> wrote:
>
>> Paul Berry <stereotype441 at gmail.com> writes:
>>
>> > The vec4_visitor functions don't use any VS specific data from
>> > vec4_visitor::vp.  So rename it to just "p" and change its type from
>> > struct gl_vertex_program * to struct gl_program *.  This will allow
>> > the code to be re-used for geometry shaders.
>>
>> In many other places in the driver, "p" is a brw_compile.  I'd rather
>> not overload that name.  In a couple other cases where we've had both
>> the gl_shader_program and the gl_program, the shader_program becomes
>> "shader_prog" (only about 8 instances in brw_vec4) and gl_program gets
>> to be just "prog"
>>
>
> That seems reasonable to me.  I'll break this out into two patches, one to
> rename struct gl_shader_program *prog to shader_prog, and another to change
> the type of vp and rename it to prog.
>
> Note that gl_shader_program *prog appears in the backend_visitor base
> class, so renaming it will affect fs code too.

Sounds good.  More consistency on this front will only help my sanity.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130409/7bb5d9bc/attachment-0001.pgp>