[Mesa-dev] [PATCH 1/2] i965: NULL check prog on compilation failure.

[Eric Anholt]

Matt Turner <mattst88 at gmail.com> writes:

> I believe that prog can only be NULL for ARB programs. Neither
> brw_fs_fp.cpp nor brw_vec4_vp.cpp call fail(), but not NULL checking
> prog is obviously fragile.

(shader != NULL) <=> (prog != NULL), so if you want consistency I'd
rather see the if (shader) changed to if (prog).  A bunch of these
changes are not about compilation failure, anyway.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130409/fbb2ffaa/attachment.pgp>