[Mesa-dev] [PATCH 1/2] i965: NULL check prog on compilation failure.

[Eric Anholt]

Kenneth Graunke <kenneth at whitecape.org> writes:

> On 04/09/2013 03:55 PM, Eric Anholt wrote:
>> Matt Turner <mattst88 at gmail.com> writes:
>>
>>> I believe that prog can only be NULL for ARB programs. Neither
>>> brw_fs_fp.cpp nor brw_vec4_vp.cpp call fail(), but not NULL checking
>>> prog is obviously fragile.
>>
>> (shader != NULL) <=> (prog != NULL), so if you want consistency I'd
>> rather see the if (shader) changed to if (prog).  A bunch of these
>> changes are not about compilation failure, anyway.
>
> Is that so?  What about fixed-function VS and a GLSL fragment shader?
> I think that's allowed in at least some older specs, and there won't be 
> a gl_shader for the VS, but I'd be surprised if there wasn't a 
> gl_shader_program...

The VS compiler will have no shader and no prog in that case.
Similarly, for ARB_sso, the VS and FS will each have a different prog.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130410/f1eb669c/attachment.pgp>