[Mesa-dev] [PATCH 06/12] glsl: Add lowering pass for ir_triop_vector_insert

Eric Anholt eric at anholt.net
Wed Apr 10 08:10:54 PDT 2013


Ian Romanick <idr at freedesktop.org> writes:

> On 04/09/2013 10:29 AM, Eric Anholt wrote:
>> Ian Romanick <idr at freedesktop.org> writes:
>> I know our hardware doesn't like the swizzling of that bvec compare
>> result and we'd rather just see individual compares as the condition of
>> each if statement.  (we basically have to emit a compare of the swizzled
>> bool against 0, after masking its high bits off, when we could have just
>> compared the index value to a constant).  I imagine other hardware would
>> prefer the same.
>
> Should we add a lowering pass or an option of some sort?

I think neither -- just rewrite this code the way our hardware wants it,
because it will be better, and it's not a pattern we'll see from user
code.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130410/f6be3df3/attachment.pgp>


More information about the mesa-dev mailing list