[Mesa-dev] [PATCH v2 07/19] i965/vs: split brw_vs_prog_data into generic and VS-specific parts.

[Eric Anholt]

Paul Berry <stereotype441 at gmail.com> writes:

> This will allow the generic parts to be re-used for geometry shaders.
>
> Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>
>
> v2: Put urb_read_length and urb_entry_size in the generic struct.

It seems like a lot of churn would be avoided if the patch 12 contents
of "actually, let's have two names pointing the different types" got
folded into this patch -- you rename usages to prog_data->base.whatever
here, and then turn it right back in 5 patches.

But the end result is fine, and you're probably tired of respinning
this, so either way patches 1-15 and 19 are:

Reviewed-by: Eric Anholt <eric at anholt.net>

For 16-18, I'm having a hard time doing any meaningful review without GS
code to compare to.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130410/8d5f22d2/attachment.pgp>