[Mesa-dev] [PATCH 04/12] intel: Improve diagnostics for emit_linear_blit failure path.

Eric Anholt eric at anholt.net
Thu Apr 11 11:06:31 PDT 2013


This fixes unused variable warnings in the release build, and should be
more useful if it ever triggers.
---
 src/mesa/drivers/dri/intel/intel_blit.c |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/mesa/drivers/dri/intel/intel_blit.c b/src/mesa/drivers/dri/intel/intel_blit.c
index 0946972..1f3fad5 100644
--- a/src/mesa/drivers/dri/intel/intel_blit.c
+++ b/src/mesa/drivers/dri/intel/intel_blit.c
@@ -480,6 +480,7 @@ intel_emit_linear_blit(struct intel_context *intel,
 		       unsigned int src_offset,
 		       unsigned int size)
 {
+   struct gl_context *ctx = &intel->ctx;
    GLuint pitch, height;
    bool ok;
 
@@ -496,7 +497,8 @@ intel_emit_linear_blit(struct intel_context *intel,
 			  0, 0, /* dst x/y */
 			  pitch, height, /* w, h */
 			  GL_COPY);
-   assert(ok);
+   if (!ok)
+      _mesa_problem(ctx, "Failed to linear blit %dx%d\n", pitch, height);
 
    src_offset += pitch * height;
    dst_offset += pitch * height;
@@ -511,7 +513,8 @@ intel_emit_linear_blit(struct intel_context *intel,
 			     0, 0, /* dst x/y */
 			     size, 1, /* w, h */
 			     GL_COPY);
-      assert(ok);
+      if (!ok)
+         _mesa_problem(ctx, "Failed to linear blit %dx%d\n", size, 1);
    }
 }
 
-- 
1.7.10.4



More information about the mesa-dev mailing list