[Mesa-dev] [PATCH] mesa: fix type comparison error in sub-texture error checking code

[Ian Romanick]

On 04/16/2013 11:07 PM, Tapani Pälli wrote:
> patch fixes a crash that happens if glTexSubImage2D is called with a
> negative xoffset.
>
> Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
> ---
>   src/mesa/main/teximage.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c
> index 784b389..ae053e8 100644
> --- a/src/mesa/main/teximage.c
> +++ b/src/mesa/main/teximage.c
> @@ -1536,7 +1536,7 @@ error_check_subtexture_dimensions(struct gl_context *ctx,
>      }
>
>      /* check xoffset and width */
> -   if (xoffset < -destImage->Border) {
> +   if (xoffset < (GLint) -destImage->Border) {
>         _mesa_error(ctx, GL_INVALID_VALUE, "%s%dD(xoffset)",
>                     function, dims);
>         return GL_TRUE;
>

I agree with Brian's suggestions.  When you re-submit, please add

NOTE: This is a candidate for the stable branches.

to the commit message.