[Mesa-dev] [PATCH 05/14] mesa, i965: use NewDriverState to communicate TFB state changes with the driver

[Eric Anholt]

Marek Olšák <maraeo at gmail.com> writes:

> _NEW_TRANSFORM_FEEDBACK is not used by core Mesa, so it can be removed.
> Instead, an new private flag is added to i965 to serve the same purpose.
>
> If you're new to this:

> diff --git a/src/mesa/drivers/dri/i965/brw_state_upload.c b/src/mesa/drivers/dri/i965/brw_state_upload.c
> index 8c56245..083b619 100644
> --- a/src/mesa/drivers/dri/i965/brw_state_upload.c
> +++ b/src/mesa/drivers/dri/i965/brw_state_upload.c
> @@ -345,7 +345,6 @@ static struct dirty_bit_map mesa_bits[] = {
>     DEFINE_BIT(_NEW_PROGRAM_CONSTANTS),
>     DEFINE_BIT(_NEW_BUFFER_OBJECT),
>     DEFINE_BIT(_NEW_FRAG_CLAMP),
> -   DEFINE_BIT(_NEW_TRANSFORM_FEEDBACK),
>     DEFINE_BIT(_NEW_VARYING_VP_INPUTS),
>     {0, 0, 0}
>  };

There should be a corresponding DEFINE_BIT addition for
BRW_NEW_TRANSFORM_FEEDBACK.

With that fixed in this patch and the NEW_RASTERIZER_DISCARD, these two
patches are:

Reviewed-by: Eric Anholt <eric at anholt.net>

I think that's all the review for this series now?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130417/3f2b1cff/attachment.pgp>