[Mesa-dev] [PATCH 2/2] i965: Remove strange comments about math functions.

Kenneth Graunke kenneth at whitecape.org
Tue Apr 23 00:24:04 PDT 2013


On 04/22/2013 09:48 PM, Matt Turner wrote:
> ---
> Do these comments make sense to anyone else?
>
>   src/mesa/drivers/dri/i965/brw_defines.h |    6 +++---
>   1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_defines.h b/src/mesa/drivers/dri/i965/brw_defines.h
> index ea5d2af..6517f24 100644
> --- a/src/mesa/drivers/dri/i965/brw_defines.h
> +++ b/src/mesa/drivers/dri/i965/brw_defines.h
> @@ -1034,9 +1034,9 @@ enum brw_message_target {
>   #define BRW_MATH_FUNCTION_EXP                              3
>   #define BRW_MATH_FUNCTION_SQRT                             4
>   #define BRW_MATH_FUNCTION_RSQ                              5
> -#define BRW_MATH_FUNCTION_SIN                              6 /* was 7 */
> -#define BRW_MATH_FUNCTION_COS                              7 /* was 8 */
> -#define BRW_MATH_FUNCTION_SINCOS                           8 /* was 6 */
> +#define BRW_MATH_FUNCTION_SIN                              6
> +#define BRW_MATH_FUNCTION_COS                              7
> +#define BRW_MATH_FUNCTION_SINCOS                           8 /* gen4, gen5 */
>   #define BRW_MATH_FUNCTION_FDIV                             9 /* gen6+ */
>   #define BRW_MATH_FUNCTION_POW                              10
>   #define BRW_MATH_FUNCTION_INT_DIV_QUOTIENT_AND_REMAINDER   11

Nope, they never have.  Both patches are:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>


More information about the mesa-dev mailing list