[Mesa-dev] [PATCH] i965: Avoid recompiles for fragment clamping on non-clamping APIs.

[Kenneth Graunke]

On 04/23/2013 09:15 PM, Jordan Justen wrote:
> On Tue, Apr 23, 2013 at 5:41 PM, Kenneth Graunke <kenneth at whitecape.org> wrote:
>> On 04/19/2013 10:54 AM, Eric Anholt wrote:
>>>
>>> Removes 75/78 state-dependent recompiles in GLB2.7 (the remaining 3 are
>>> due to FBO-rendering size predictions).
>>
>>
>> AFAICT ClampColor is not deprecated in OpenGL Core.  It doesn't exist in ES,
>> though.
>>
>> If you change it to _mesa_is_desktop_gl(ctx), you can have a R-b.
>
> glspec31.20090528, E.1 Profiles and Deprecated Features of OpenGL 3.0:
>
> "Note that the FrontFace and ClampColor commands are not deprecated,
> as they still affect other non-deprecated functionality; however, the Clam-
> pColor targets CLAMP_VERTEX_COLOR and CLAMP_FRAGMENT_COLOR are
> deprecated."
>
> Does that mean Eric's original change is okay?
>
> -Jordan

You're correct, of course (it's been a long day).  ClampColor still 
exists but only to toggle clamping on readback, not vertex/fragment 
color clamping.

So, sorry Eric, your original patch gets a:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

Thanks Jordan.