[Mesa-dev] [PATCH] draw: Change slot from unsigned to int.

[Brian Paul]

On 08/04/2013 12:49 AM, Vinson Lee wrote:
> unfilled_stage::face_slot is of type int.
>
> Fixes "Unsigned compared against 0" defect reported by Coverity.
>
> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
> ---
>   src/gallium/auxiliary/draw/draw_pipe_unfilled.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/auxiliary/draw/draw_pipe_unfilled.c b/src/gallium/auxiliary/draw/draw_pipe_unfilled.c
> index d8a603f..e31c273 100644
> --- a/src/gallium/auxiliary/draw/draw_pipe_unfilled.c
> +++ b/src/gallium/auxiliary/draw/draw_pipe_unfilled.c
> @@ -66,7 +66,7 @@ inject_front_face_info(struct draw_stage *stage,
>      boolean is_front_face = (
>         (stage->draw->rasterizer->front_ccw && ccw) ||
>         (!stage->draw->rasterizer->front_ccw && !ccw));
> -   unsigned slot = unfilled->face_slot;
> +   int slot = unfilled->face_slot;
>      struct vertex_header *v0 = header->v[0];
>      struct vertex_header *v1 = header->v[1];
>      struct vertex_header *v2 = header->v[2];
>

Reviewed-by: Brian Paul <brianp at vmware.com>