[Mesa-dev] [PATCH] nvc0: Initialize ptr for unexpected sample_count on release builds.

Brian Paul brianp at vmware.com
Mon Aug 5 07:02:14 PDT 2013


On 08/04/2013 01:51 AM, Vinson Lee wrote:
> Fixes "Uninitialized pointer read" defect reported by Coverity.
>
> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
> ---
>   src/gallium/drivers/nvc0/nvc0_context.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/src/gallium/drivers/nvc0/nvc0_context.c b/src/gallium/drivers/nvc0/nvc0_context.c
> index cd86040..8cd5fc5 100644
> --- a/src/gallium/drivers/nvc0/nvc0_context.c
> +++ b/src/gallium/drivers/nvc0/nvc0_context.c
> @@ -394,6 +394,7 @@ nvc0_context_get_sample_position(struct pipe_context *pipe,
>      case 8: ptr = ms8; break;
>      default:
>         assert(0);
> +      ptr = ms1;
>         break;
>      }
>      xy[0] = ptr[sample_index][0] * 0.0625f;
>

Reviewed-by: Brian Paul <brianp at vmware.com>



More information about the mesa-dev mailing list