[Mesa-dev] [PATCH] egl: Do not export private symbols

[Jakob Bornecrantz]

On Wed, Aug 7, 2013 at 12:00 AM, Jakob Bornecrantz <wallbraker at gmail.com>wrote:

> On Tue, Aug 6, 2013 at 9:21 PM, Chad Versace <chad.versace at linux.intel.com
> > wrote:
>
>> libEGL was incorrectly exporting *all* symbols, public and private.
>> This patch adds -fvisibility=hidden to libEGL's linker flags to ensure
>> that only symbols annotated with __attribute__((visibility("default")))
>> get exported.
>>
>> Sanity-checked on X11/EGL with Piglit, and on Wayland by running
>> weston-gears.
>>
>
> You need to test this patch on a non-inbuilt driver, egl_gallium or
> egl_glx,
> none of which require you to have any hardware. Or force egl_dri2 to not
> be built in.
>

Do that and you have my
Reviewed-by: Jakob Bornecrantz <jakob at vmware.com>

Cheers, Jakob.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130807/600b2e22/attachment-0001.html>