[Mesa-dev] [i965][V2] i965/draw: Move constant formation outside of for loop and use an enum.

[Eric Anholt]

Mark Mueller <markkmueller at gmail.com> writes:
> Signed-off-by: Mark Mueller <MarkKMueller at gmail.com>
> ---
>  src/mesa/drivers/dri/i965/brw_draw.c | 16 ++++++----------
>  1 file changed, 6 insertions(+), 10 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_draw.c b/src/mesa/drivers/dri/i965/brw_draw.c
> index 6170d07..1b5ed55 100644
> --- a/src/mesa/drivers/dri/i965/brw_draw.c
> +++ b/src/mesa/drivers/dri/i965/brw_draw.c
> @@ -367,6 +367,12 @@ static bool brw_try_draw_prims( struct gl_context *ctx,
>     bool retval = true;
>     GLuint i;
>     bool fail_next = false;
> +   const int estimated_max_prim_size =
> +           512 + /* batchbuffer commands */
> +           ((BRW_MAX_TEX_UNIT * (sizeof(struct brw_sampler_state) + sizeof(struct gen5_sampler_default_color)))) +
> +           1024 + /* gen6 VS push constants */
> +           1024 + /* gen6 WM push constants */
> +           512; /* misc. pad */

What's the point of this change?  Moving loop invariants out of loops is
something basic that your compiler does, and you're moving the
definition farther from its use.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130808/bf0df8ce/attachment.pgp>