[Mesa-dev] spec/!OpenGL 3.0/gl-3.0-texture-integer fails on r600g

[Martin Andersson]

I think I have found an issue in the piglit test.

Marek, could you take a look at the attached patch and see if it looks
correct. If so I will send it to the piglit list.

//Martin

On Tue, Aug 6, 2013 at 11:20 PM, Marek Olšák <maraeo at gmail.com> wrote:
> Sorry, I have no idea. You can try to remove support for RGBX integer
> formats and see if it helps.
>
> In is_format_supported, return FALSE for all R?G?B?X_?INT formats.
>
> Marek
>
> On Sat, Aug 3, 2013 at 11:51 AM, Martin Andersson <g02maran at gmail.com> wrote:
>> Well, I should have been more clear. If I do this:
>>
>> 263: value[3] = 0;
>> 290: expected[3] = 1.0;
>>
>> The test always passes, but if I only do this:
>>
>> 290: expected[3] = 1.0;
>>
>> The test fails with this error:
>>
>> texture-integer: failure with format GL_RGB8I_EXT:
>>   texture color = 92, 126, 14, 104
>>   expected color = 0.25, 0.5, 0.75, 1
>>   result color = 0.25098, 0.501961, 0.74902, 0
>> PIGLIT: {'result': 'fail' }
>>
>> //Martin
>>
>> On Sat, Aug 3, 2013 at 5:23 AM, Marek Olšák <maraeo at gmail.com> wrote:
>>> FragShaderText contains the shader code. Anyway, we have found the
>>> issue: expected[3] should really be set to 1.0, because RGB formats
>>> must return (r,g,b,1). It's a bug in the piglit test.
>>>
>>> Marek
>>>
>>> On Fri, Aug 2, 2013 at 11:44 PM, Martin Andersson <g02maran at gmail.com> wrote:
>>>> On Fri, Aug 2, 2013 at 2:52 PM, Marek Olšák <maraeo at gmail.com> wrote:
>>>>> The format doesn't have alpha. See what the texture fetch writes to
>>>>> the alpha channel.
>>>>
>>>> I looked at the code but I can't figure out where the texture fetch
>>>> happens, could you point me in the right direction?
>>>>
>>>>>
>>>>> You may try setting "texture-integer.c:290" to "expected[3] = 1.0;"
>>>>
>>>> The test passes if I do that.
>>>>
>>>> //Martin
>>>>
>>>>>
>>>>> Marek
>>>>>
>>>>> On Fri, Aug 2, 2013 at 2:15 PM, Martin Andersson <g02maran at gmail.com> wrote:
>>>>>> Hi,
>>>>>>
>>>>>> I started to look at why the spec/!OpenGL 3.0/gl-3.0-texture-integer
>>>>>> sometimes fails on my AMD 6950, using mesa master. It fails with
>>>>>> errors like this:
>>>>>>
>>>>>> texture-integer: failure with format GL_RGB8I_EXT:
>>>>>>   texture color = 100, 9, 71, 0
>>>>>>   expected color = 0.25, 0.5, 0.75, 0
>>>>>>   result color = 0.25098, 0.501961, 0.74902, 1
>>>>>> PIGLIT: {'result': 'fail' }
>>>>>>
>>>>>> When I ran the test a bunch of times I found that it only failed when
>>>>>> the last texture color was zero. So when I changed this code in the
>>>>>> pigilt test:
>>>>>>
>>>>>> value[0] = rand() % max;
>>>>>> value[1] = rand() % max;
>>>>>> value[2] = rand() % max;
>>>>>> value[3] = rand() % max;
>>>>>>
>>>>>> to this:
>>>>>>
>>>>>> value[0] = rand() % max;
>>>>>> value[1] = rand() % max;
>>>>>> value[2] = rand() % max;
>>>>>> value[3] = 0;
>>>>>>
>>>>>> The test always fails.
>>>>>>
>>>>>> I found this bug https://bugs.freedesktop.org/show_bug.cgi?id=63664
>>>>>> But I can't reproduce this bug on my intel G45 (running mesa 9.1.5).
>>>>>>
>>>>>> Anyone know what is causing this or how I could debug it further?
>>>>>>
>>>>>> //Martin
>>>>>> _______________________________________________
>>>>>> mesa-dev mailing list
>>>>>> mesa-dev at lists.freedesktop.org
>>>>>> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-texture-integer-fix-alpha-issue-with-GL_RGB_INTEGER_.patch
Type: application/octet-stream
Size: 1033 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130809/df6dd5d5/attachment.obj>