[Mesa-dev] [PATCH 01/15] i965/fs: Skip global copy propagation step.

Kenneth Graunke kenneth at whitecape.org
Mon Aug 12 13:11:21 PDT 2013


The dataflow analysis used for global copy propagation is severely
broken, and I believe it doesn't actually do anything.  Fixing it will
require a lot of changes, each of which might break things.

Once all the fixes land, we can re-enable this.

Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
---
 src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp b/src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp
index 234f8bd..d8d1546 100644
--- a/src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp
+++ b/src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp
@@ -445,6 +445,7 @@ fs_visitor::opt_copy_propagate()
                                           out_acp[b]) || progress;
    }
 
+   #if 0
    /* Do dataflow analysis for those available copies. */
    fs_copy_prop_dataflow dataflow(mem_ctx, &cfg, out_acp);
 
@@ -464,6 +465,7 @@ fs_visitor::opt_copy_propagate()
 
       progress = opt_copy_propagate_local(mem_ctx, block, in_acp) || progress;
    }
+   #endif
 
    for (int i = 0; i < cfg.num_blocks; i++)
       delete [] out_acp[i];
-- 
1.8.3.4



More information about the mesa-dev mailing list