[Mesa-dev] [PATCH 3/3] mesa: Use _mesa_detach_renderbuffer when deleting a texture

Chad Versace chad.versace at linux.intel.com
Mon Aug 12 14:16:50 PDT 2013


On 08/08/2013 04:23 PM, Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
>
> The functional change is that now invalidate_framebuffer is called if
> the texture is actually detached from one of the currently bound FBOs.
> Previously this was only done for renderbuffers.
>
> The remaining changes make the texture delete path look more similar to
> the renderbuffer delete path.  This includes adding relevant spec
> quotations to justify the behavior.
>
> Fixes piglit fbo-incomplete "delete texture of bound FBO" test.
>
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> Cc: "9.2" mesa-stable at lists.freedesktop.org
> ---
>   src/mesa/main/fbobject.c | 23 +++++++++++++++++++----
>   src/mesa/main/texobj.c   | 42 +++++++++++++++++++++++++++---------------
>   2 files changed, 46 insertions(+), 19 deletions(-)

Other than the missplaced hunk in patch 2, this series looks good to me. Move
that hunk and the series is
Reviewed-by: Chad Versace <chad.versace at linux.intel.com>



More information about the mesa-dev mailing list