[Mesa-dev] [PATCH 13/15] i965/fs: Fully recompute liveout at each step.

[Paul Berry]

On 12 August 2013 13:11, Kenneth Graunke <kenneth at whitecape.org> wrote:

> Since we start with an overestimation of livein (0xffffffff), successive
> steps may should actually take away values.  This means we can't simply
>

Is "may should" a Southernism?

In any case,

Reviewed-by: Paul Berry <stereotype441 at gmail.com>


> OR in new liveout values; we need to recompute it from scratch at each
> iteration of the fixed-point algorithm.
>
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> ---
>  src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp
> b/src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp
> index f5c8e4a..9522649 100644
> --- a/src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp
> @@ -219,7 +219,7 @@ fs_copy_prop_dataflow::run()
>           for (int i = 0; i < bitset_words; i++) {
>              const BITSET_WORD old_liveout = bd[b].liveout[i];
>
> -            bd[b].liveout[i] |=
> +            bd[b].liveout[i] =
>                 bd[b].copy[i] | (bd[b].livein[i] & ~bd[b].kill[i]);
>
>              if (old_liveout != bd[b].liveout[i])
> --
> 1.8.3.4
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130815/d7547c1a/attachment.html>