[Mesa-dev] [PATCH 2/2] i965: Don't copy propagate bitcasts with source modifiers.

Paul Berry stereotype441 at gmail.com
Fri Aug 16 08:27:10 PDT 2013


On 15 August 2013 16:19, Matt Turner <mattst88 at gmail.com> wrote:

> Previously, copy propagation would cause bitcast_f2u(abs(float)) to
> be performed in a single step, but the application of source modifiers
> (abs, neg) happens after type conversion, leading to incorrect results.
>
> That is, for bitcast_f2u(abs(float)) we would in fact generate code to
> do abs(bitcast_f2u(float)).
>
> For example, whereas bitcast_f2u(abs(float)) might result in a register
> argument such as
>    (abs)g2.2<0,1,0>UD
>
> v2: Set interfered = true and break in register_coalesce instead of
>     returning false.
>

Reviewed-by: Paul Berry <stereotype441 at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130816/6ea4cf16/attachment.html>


More information about the mesa-dev mailing list