[Mesa-dev] [PATCH] i965: STATIC_ASSERT that there aren't too many BRW_NEW_* flags.

Kenneth Graunke kenneth at whitecape.org
Sun Aug 18 13:22:58 PDT 2013


On Sunday, August 18, 2013 09:34:37 AM Paul Berry wrote:
> We are getting close to the maximum number of BRW_NEW_* bits that can
> be stored in brw->state.dirty.brw without overflowing 32 bits, and
> geometry shaders are going to add more.  Add a STATIC_ASSERT so that
> we will be alerted when we need to switch to 64 bits.

Good idea.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

Moving to 64-bit values is a bit trickier.  ctx->DriverFlags uses GLbitfields 
for which flags to set, so we probably ought to expand those to 64-bit as 
well.   Which may need changes in other drivers.

Nothing hard, just something people might neglect.


More information about the mesa-dev mailing list