[Mesa-dev] [PATCH 00/30] i965/gen7: Initial geometry shader support.

[Paul Berry]

On 20 August 2013 11:30, Paul Berry <stereotype441 at gmail.com> wrote:

> This series constitutes the initial geometry shader support for i965
> Gen7 (Ivy Bridge) and Gen7.5 (Haswell).
>
> Basic functionality works, but I haven't turned it on yet because the
> following tasks still need to be done:
>
> - Get sampling to work
>
> - Support EndPrimitive()
>
> - Support gl_PrimitiveID (and gl_PrimitiveIDIn)
>
> - Support >64 varying components
>
> - Support new primitive types (e.g. GL_TRIANGLES_ADJACENCY)
>
> - Support built-in variables being used as GS inputs
>   (e.g. gl_in[].gl_PointSize)
>
> - A lot more testing
>
> Patches 01-02 do some minor core mesa refactoring needed by this
> series.
>
> Patches 03-13 do basic prep work (mostly refactoring).
>
> Patches 14-19 create the vec4_gs_visitor class, which translates
> geometry shaders from GLSL IR to back-end opcodes (it is parallel to
> the existing vec4_vs_visitor class).
>
> Patches 20-25 create the brw_vec4_gs_prog state atom, which invokes
> back-end geometry shader compilation when demanded by a change to the
> GL pipeline state.
>
> Patches 26-28 modify the URB configuration to make room for geometry
> shader push constants and geometry shader output data.
>
> Patches 29-30 create the gen7_gs_push_constants and gen7_gs_state
> state atoms, which cause the geometry shader portion of the pipeline
> to be programmed properly when a geometry shader is in use.
>
> This series is available on branch "gs-phase-2" of
> https://github.com/stereotype441/mesa.git.  Additional unfinished
> geometry shader work is in branch "gs".  Note that the "gs" branch is
> rebased very frequently.
>
> Thanks in advance for your review!
>

Yesterday most of the Intel team had an in-person review of patches 1-23,
and started reviewing patch 24.  I've sent my notes from the review out in
reply to the individual patch emails.  Feel free to reply and make
corrections if I've missed something.

Ian gave his review to patches 1-22, assuming the noted changes are made.
If anyone else would like to be mentioned in "Reviewed-by" tags, let me
know.

We decided we would like to try landing patches 1-22 as soon as possible,
and have a respin of the remaining patches.  Unless there are objections,
I'm going to start working on that today, and try to land patches 1-22
either today or tomorrow.  I'll plan on sending out a respin of patches
23-30 next week.

We also discussed the possibility that once this series lands, we can start
dividing up my remaining geometry shader to-do list items.  I'll plan on
coordinating that with people next week as well.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130822/6d9bbe64/attachment.html>