[Mesa-dev] [PATCH] nouveau/video: avoid overwriting base codec init with template

[Koenig, Christian]

The offending patch didn't went into 9.2, so no harm done there.

Going to commit the fix as soon as I'm home again.

Christian.

Sent from my Android phone using TouchDown (www.nitrodesk.com)

-----Original Message-----
From: Ilia Mirkin [imirkin at alum.mit.edu]
Received: Samstag, 24 Aug. 2013, 16:02
To: Martin Peres [martin.peres at labri.fr]
CC: Koenig, Christian [Christian.Koenig at amd.com]; Maarten Lankhorst [maarten.lankhorst at ubuntu.com]; mesa-dev at lists.freedesktop.org [mesa-dev at lists.freedesktop.org]
Subject: Re: [PATCH] nouveau/video: avoid overwriting base codec init with template

On Sat, Aug 24, 2013 at 8:36 AM, Martin Peres <martin.peres at labri.fr> wrote:
> On 24/08/2013 11:38, Christian König wrote:
>>
>> Am 24.08.2013 06:50, schrieb Ilia Mirkin:
>>>
>>> Commit 53e20b8b introduced the use of a template to initialize some
>>> common fields. Move this copying of fields to before the common vp3
>>> fields are initialized.
>>>
>>> Reported-by: Martin Peres <martin.peres at labri.fr>
>>> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
>>
>>
>> Sorry, that some fields are initialized earlier wasn't obviously to me.

It wasn't obvious to me either at first -- I saw the changes and they
looked fine :)

>>
>> Patch is: Reviewed-by: Christian König <christian.koenig at amd.com>

Thanks! I don't have commit access, so I'd appreciate it if you could
check it in. You can pull it from https://github.com/imirkin/mesa
bugfixes if you prefer to use git.

> This patch should also be pushed in 9.2 before its release.

I don't think that the "use the template" patches went into 9.2, so
this patch is also not appropriate for 9.2 (it wouldn't apply).

  -ilia

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130824/5e387a6e/attachment.html>