[Mesa-dev] [PATCH 1/2] i965/vs: Detect GRF sources in split_virtual_grfs send-from-GRF code.

[Eric Anholt]

Kenneth Graunke <kenneth at whitecape.org> writes:

> It is incorrect to assume that src[0] of a SEND-from-GRF opcode is the GRF.
> VS_OPCODE_PULL_CONSTANT_LOAD_GEN7 uses an IMM as src[0], and stores the
> GRF as src[1].
>
> To be safe, loop over all the source registers and mark any GRFs.  We
> probably won't ever have more than one, but it's simpler to just check
> all three rather than attempting to bail early.
>
> Fixes assertion failures in Unigine Sanctuary since we started making
> register allocation rely on split_virtual_grfs working.  (The register
> classes were actually sufficient, we were just interpreting an IMM as
> a virtual GRF number.)
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=68637
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> Cc: mesa-stable at lists.freedesktop.org

These are:

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130828/1cf4ce1f/attachment-0001.pgp>