[Mesa-dev] [PATCH 13/22] i965/gs: Implement support for geometry shader surfaces.

Kenneth Graunke kenneth at whitecape.org
Wed Aug 28 18:11:01 PDT 2013


On 08/26/2013 03:12 PM, Paul Berry wrote:
> This patch implements pull constant upload, binding table upload, and
> surface setup for geometry shaders, by re-using vertex shader code
> that was generalized in previous patches.
>
> Based on work by Eric Anholt <eric at anholt.net>.

This looks a lot better than the previous version.

I've never really been crazy about having binding table code split 
across brw_vs_surface_state.c and brw_wm_surface_state.c, with the bulk 
of the code in the WM file for some reason.  This adds a third file, and 
I'm not crazy about that either.

Still, I vote that we land brw_gs_surface_state.c as is now; we can 
always do more tidying and code motion after the fact.

--Ken


More information about the mesa-dev mailing list