[Mesa-dev] [PATCH 0/6] radeonsi: Minor cleanups and improvements

[Marek Olšák]

On Thu, Aug 29, 2013 at 12:20 PM, Christian König
<deathsimple at vodafone.de> wrote:
> Am 28.08.2013 19:17, schrieb Marek Olšák:
>
>> This series contains the changes my transform feedback work depends on,
>> but there are some useful fixes too, making it worth comitting earlier.
>>
>> The last patch is the most important one, because it fixes the issues we
>> had with the emission of resource descriptors that we had to use 256
>> resource contexts as a workaround. Further testing has shown that even 256
>> wasn't enough. With that patch, we only need 8 or 16 contexts as originally
>> expected.
>>
>> I also made the first step towards sharing code between r600g and radeonsi
>> and it's what made this series so big:
>>
>> 54 files changed, 2448 insertions(+), 2532 deletions(-)
>>
>> Please review.
>
>
> Sounds good, one minor comment on patch 4:
>
> Why did you named the common classes r600_common_* ? My feeling would go
> more towards radeon_*
>
> Apart from that the patches seem really good to me.

Thank you.

The radeon_ prefix would suggest to me that it supports any radeon
ASICs, including r300, which isn't true. I did use radeon_* at the
beginning, but it didn't feel right. The r600_ prefix clearly states
it only supports r600 and later ASICs.

Marek