[Mesa-dev] [PATCH 01/22] i965: rename legacy gs structs and functions to ff_gs.

Chad Versace chad.versace at linux.intel.com
Thu Aug 29 16:55:27 PDT 2013


>>   @@ -208,7 +209,7 @@ static void brw_gs_emit_vue(struct brw_gs_compile *c,
>>>     * the allocated URB entry (which will be needed by the URB_WRITE
>>> meesage that
>>>     * follows).
>>>     */
>>> -static void brw_gs_ff_sync(struct brw_gs_compile *c, int num_prim)
>>> +static void brw_ff_gs_ff_sync(struct brw_ff_gs_compile *c, int num_prim)
>>>    {
>>>       struct brw_compile *p = &c->func;
>>>
>>>
>> Looks like you double-edited this hunk. "brw_ff_gs_ff".
>>
>
> Sadly, no.  The first "ff" is the "ff" I'm adding.  The second "ff" is part
> of "ff_sync", which is the name of a URB message (see Graphics BSpec:
> 3D-Media-GPGPU Engine > Shared Functions > URB > URB Messages [DevSNB] >
> FF_SYNC Messages).  It's a rather unfortunate coincidence that makes the
> name look like a mistake :(


Doh. Ok.


>> Fix that, and patch 1 is
>> Reviewed-by: Chad Versace <chad.versace at linux.intel.com>



More information about the mesa-dev mailing list