[Mesa-dev] [PATCH 21/22] i965/gen7: Generalize gen7_vs_state in preparation for GS.

[Eric Anholt]

Kenneth Graunke <kenneth at whitecape.org> writes:

> On 08/29/2013 04:06 PM, Eric Anholt wrote:
>>     emit_constants(3DSTATE_CONSTANT_VS, &brw->vs.stage_state);
>
> I'm fine with putting the constant emission into a helper function. 
> Although it's simple code, it's quite a few lines, so factoring it out 
> would make things more concise.  All stages could easily reuse it.
>
> Plus, that function would have a single, obvious purpose - emit 
> 3DSTATE_CONSTANT_XS for some X.

That's actually what I'd prefer, too.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130830/025626e9/attachment.pgp>