[Mesa-dev] [PATCH 06/23] i965: Define common register base class shared between both back-ends.

[Chris Forbes]

Ideally, we wouldn't need init() and you could just have a
copy-constructor do the right thing, I think -- currently, all the
backend_reg fields get initialized 3 times:

- backend_reg ctor
- init() blasting everything to zero
- this assignment



On Tue, Dec 3, 2013 at 9:22 AM, Francisco Jerez <currojerez at riseup.net> wrote:
> Chris Forbes <chrisf at ijw.co.nz> writes:
>
>> +fs_reg::fs_reg(const backend_reg &reg)
>> +{
>> +   init();
>> +   *static_cast<backend_reg *>(this) = reg;
>>
>> This is a bit gross...
>
> Would you prefer 'this->operator=(reg);'?
>
> Meh... :)