[Mesa-dev] [PATCH 1/2] Allow for GLSL shaders to have #extension directive anywhere in source file.

[Rogovin, Kevin]

Hi,


> Yeah...there's a point where you switch from the old code to the new
> code, and most bugs would probably bisect to that.  In this case, I
> think that's fairly unavoidable.
>
> However, splitting it up into multiple patches would definitely make it
> a lot easier to review.

So, is it required to do the split or not? My opinion is that it is easier to
review as one patch as it keeps the context of the changes too. I think
it is a very BAD^tm thing when a patch adds dead code, it makes me 
shudder. I also freely admit that I do think that the patch I submitted was
small-ish in terms of scale: the refactoring was tiny, and so on. Indeed
I have seen patches that change much more get the OK as well. 

-Kevin