[Mesa-dev] [Mesa-stable] [PATCH v3] egl: add HAVE_LIBDRM define, fix EGL X11 platform

[Chad Versace]

On 12/02/2013 09:55 PM, Tapani Pälli wrote:
> On 12/02/2013 11:06 PM, Chad Versace wrote:
>> On 12/01/2013 01:53 AM, Tapani Pälli wrote:
>>> Commit a594cec broke EGL X11 backend by adding dependency between
>>> X11 and DRM backends requiring HAVE_EGL_PLATFORM_DRM defined for X11.
>>>
>>> This patch fixes the issue by adding additional define for libdrm
>>> detection independent of which backend is being compiled. Tested by
>>> compiling Mesa with '--with-egl-platforms=x11' and running es2gears_x11
>>> + glbenchmark2.7 successfully.
>>>
>>> v2: return true for dri2_auth if running without libdrm (Samuel)
>>> v3: check libdrm when building EGL drm platform + AM_CFLAGS fix (Emil)
>>>
>>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=72062
>>> Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
>>> Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>
>>> Cc: Samuel Thibault <samuel.thibault at ens-lyon.org>
>>> Cc: mesa-stable at lists.freedesktop.org
>>
>>
>> I tested this patch with --with-egl-platforms=x11, and it works
>> for me.
>>
>> But, why return true from dri2_authenticate() when building
>> without libdrm? I expected dri2_authenticate() to return false
>> in that case, because the function never authenticates with the
>> Xserver without drmGetMagic().
>>
>
> I hope Samuel is able to answer this. I'm not sure which platform/driver uses this configuration, I was trying to ask
> for it also in the bug to be able to test this. I can also leave that change out for now and return FALSE by default if
> no conclusion to this.

 > I'd really like a working EGL ...

A working EGL is better than a slightly buggy EGL, so I've committed the patch to master.

Samuel, please explain why you requested that dri2_authenticate() return true when HAVE_LIBDRM == false.
Are you using some arcane build configuration that requires this?

I want it to return false because, without libdrm, the function never authenticates with the Xserver.
No authentication occurs, so the function should return false.