[Mesa-dev] [PATCH 3/3] i965: Fix BRW_BATCH_STRUCT to specify RENDER_RING, not UNKNOWN_RING.

Eric Anholt eric at anholt.net
Tue Dec 3 15:19:30 PST 2013


Kenneth Graunke <kenneth at whitecape.org> writes:

> I missed this in the boolean -> enum conversion.  C cheerfully casts
> false -> 0 -> UNKNOWN_RING.  On Gen4-5, this causes the render ring
> prelude hook to get called in the middle of the batch, which is crazy.
>
> BRW_BATCH_STRUCT is not used on Gen6+.
>
> Fixes regressions since 395a32717df494353703f3581edcd3ba380f16d6
> ("i965: Introduce an UNKNOWN_RING state.").
>
> Fixes "fips -v glxgears" on Ironlake.
>
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> Cc: Eric Anholt <eric at anholt.net>

These are:

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20131203/2f19872d/attachment.pgp>


More information about the mesa-dev mailing list