[Mesa-dev] [PATCH 1/9] mesa: have old glColorTable functions generate GL_INVALID_OPERATION

[Ian Romanick]

On 12/04/2013 06:35 AM, Brian Paul wrote:
> On 11/23/2013 05:00 PM, Ian Romanick wrote:
>> Patches 1 through 6 and 9 are
>>
>> Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>.
>>
>> I actually wonder if in non-debug builds we should use function aliasing
>> (or similar) to use generic_noop for all these functions that just set
>> GL_INVALID_OPERATION.  That might be a good newbie project. :)
>>
>> I want to look at 7 and 8 a bit closer.
> 
> Ping.

Thanks for the reminder.  I had completely forgotten.  I don't care for
the 'n + POINTER_DWORDS' business in patch 7, but I don't have a better
suggestion either.  I don't think adding a second parameter to
alloc_instruction would be better.  /shrug/

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

> -Brian