[Mesa-dev] [PATCH 00/11] Core mesa changes for ARB_shader_image_load_store.

Francisco Jerez currojerez at riseup.net
Sat Dec 7 20:48:12 PST 2013


Paul Berry <stereotype441 at gmail.com> writes:

> On 6 December 2013 02:54, Francisco Jerez <currojerez at riseup.net> wrote:
>
>> Paul Berry <stereotype441 at gmail.com> writes:
>>
>> >[...]
>> > This order of patches introduces temporary build breakages, which I'd
>> > prefer to avoid if possible.  Here's one order which I've verified works
>> > (there may be other possibilities):
>> >
>> > [PATCH 03/11] mesa: Add state data structures requried for
>> > ARB_shader_image_load_store.
>> > [PATCH 04/11] mesa: Add driver interface for ARB_shader_image_load_store.
>> > [PATCH 06/11] mesa: Add MESA_FORMAT_ABGR2101010.
>> > [PATCH 08/11] mesa: Implement the GL entry points defined by
>> > ARB_shader_image_load_store.
>> > [PATCH 01/11] glapi: Update dispatch XML files for
>> > ARB_shader_image_load_store.
>> > [PATCH 02/11] mesa: Add ARB_shader_image_load_store to the extension
>> table.
>> > [PATCH 05/11] mesa: Add image parameter queries for
>> > ARB_shader_image_load_store.
>> > [PATCH 07/11] mesa: Add MESA_FORMAT_SIGNED_RG88 and _RG1616.
>> > [PATCH 09/11] mesa: Unbind deleted textures from the shader image units.
>> > [PATCH 10/11] mesa: Validate image units when the texture state changes.
>> > [PATCH 11/11] docs: Mark ARB_shader_image_load_store as work in progress.
>>
>> Thanks Paul, I've adopted your patch ordering in my branch, it should be
>> fixed now.
>>
>
> Cool, thanks.
>
> I sent comments on patches 1, 3, 6, and 8 (relative to the original
> ordering).  The remainder of this series is:
>
> Reviewed-by: Paul Berry <stereotype441 at gmail.com>
>
> I'll try to get to the other ARB_image_shader_load_store series next week.

I'd recommend you to start off from my image-load-store branch instead
of the patches in the mailing list, there have been many changes in
master since I sent them for review and the series doesn't apply cleanly
anymore.  I've rebased the branch and made some additional fixes
recently, it would be cool if you could have a look there.  Some testing
would be welcome too. :)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 229 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20131208/a690d2af/attachment-0001.pgp>


More information about the mesa-dev mailing list