[Mesa-dev] [PATCH 0/8] Fix multiple memory leaks

[Tom Stellard]

Hi Aaron,

Just one comment on patch 4, with that fixed the series is:

Reviewed-by: Tom Stellard <thomas.stellard at amd.com>

If you re-send an annotated series with the patch 4 fix I'll push it.
Also, can you add

CC: "10.0" <mesa-stable at lists.freedesktop.org>

so they get pulled into the stable branch.

Thanks,
Tom

On Thu, Dec 12, 2013 at 04:47:16PM -0600, Aaron Watry wrote:
> Most of these fixes target radeon (both EG and SI), but some also help
> clover, pipe loader, and also vdpau playback.
> 
> These have been tested mostly on evergreen, but I've had them running
> on my desktop (pitcairn) for a few weeks as well.
> 
> Aaron Watry (8):
>   clover: Remove unused variable
>   pipe_loader/sw: close dev->lib when initialization fails.
>   radeon/compute: Stop leaking LLVMContexts in radeon_llvm_parse_bitcode
>   r600/compute: Free compiled kernels when deleting compute state
>   r600/compute: Use the correct FREE macro when deleting compute state.
>   radeon/llvm: Free target data at end of optimization
>   st/vdpau: Destroy context when initialization fails
>   r600/pipe: Stop leaking context->start_compute_cs_cmd.buf on EG/CM
> 
>  src/gallium/auxiliary/pipe-loader/pipe_loader_sw.c |  5 ++++-
>  src/gallium/drivers/r600/evergreen_compute.c       | 24 ++++++++++++++++++----
>  .../drivers/r600/evergreen_compute_internal.h      |  4 ++++
>  src/gallium/drivers/r600/r600_pipe.c               |  2 ++
>  src/gallium/drivers/radeon/radeon_llvm_util.c      | 16 +++++++--------
>  src/gallium/drivers/radeon/radeon_llvm_util.h      |  9 ++++----
>  src/gallium/drivers/radeonsi/radeonsi_compute.c    | 13 +++++++++---
>  .../state_trackers/clover/llvm/invocation.cpp      |  1 -
>  src/gallium/state_trackers/vdpau/device.c          |  1 +
>  9 files changed, 54 insertions(+), 21 deletions(-)
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev