[Mesa-dev] [PATCH] configure.ac: remove -fcolor-diagnostics from LLVM flags

[Brian Paul]

On 12/13/2013 02:59 AM, Markus Trippelsdorf wrote:
> When LLVM is build with Clang, "llvm-config --cxxflags" contains the
> -fcolor-diagnostics flag. It is not recognized by gcc and the build
> fails. Fix by removing the flag.
>
> Signed-off-by: Markus Trippelsdorf <markus at trippelsdorf.de>
>
> diff --git a/configure.ac b/configure.ac
> index c14d39a285a6..da8be8b02f3e 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1546,6 +1546,7 @@ strip_unwanted_llvm_flags() {
>   	-e 's/-O.\>//g' \
>   	-e 's/-g\>//g' \
>   	-e 's/-Wall\>//g' \
> +	-e 's/-fcolor-diagnostics\>//g' \
>   	-e 's/-fomit-frame-pointer\>//g'
>   }
>
>

Looks OK to me.  Should this also go in the 10.0 branch?

Reviewed-by: Brian Paul <brianp at vmware.com>