[Mesa-dev] [PATCH 3/3] glsl: Replace _mesa_glsl_parser_targets enum with gl_shader_type.

[Paul Berry]

On 16 December 2013 14:42, Brian Paul <brianp at vmware.com> wrote:

> On 12/16/2013 03:27 PM, Paul Berry wrote:
>
>> These enums were redundant.
>> ---
>>   src/glsl/ast_to_hir.cpp         | 82 ++++++++++++++++++++----------
>> -----------
>>   src/glsl/builtin_functions.cpp  | 22 +++++------
>>   src/glsl/builtin_variables.cpp  | 20 +++++-----
>>   src/glsl/glsl_parser.yy         |  8 ++--
>>   src/glsl/glsl_parser_extras.cpp | 14 +++----
>>   src/glsl/glsl_parser_extras.h   | 10 +----
>>   6 files changed, 75 insertions(+), 81 deletions(-)
>>
>
> For the series:
> Reviewed-by: Brian Paul <brianp at vmware.com>
>
> I see there's more MESA_SHADER_x -> string conversion in
>
> check_resources() in linker.cpp
> link_check_atomic_counter_resources() in link_atomic.cpp
>
> Those should probably use _mesa_glsl_shader_target_name()
>

That's a good point.  I'll submit a follow-up patch.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20131216/5bce2e7a/attachment.html>