[Mesa-dev] [PATCH 1/5] main: Remove unused function _mesa_shader_index_to_type().

Brian Paul brianp at vmware.com
Tue Dec 17 10:53:51 PST 2013


On 12/17/2013 11:23 AM, Paul Berry wrote:
> ---
>   src/mesa/main/shaderobj.h | 15 ---------------
>   1 file changed, 15 deletions(-)
>
> diff --git a/src/mesa/main/shaderobj.h b/src/mesa/main/shaderobj.h
> index de1c9fc..7245c5e 100644
> --- a/src/mesa/main/shaderobj.h
> +++ b/src/mesa/main/shaderobj.h
> @@ -118,21 +118,6 @@ _mesa_shader_type_to_index(GLenum v)
>   }
>
>
> -static inline GLenum
> -_mesa_shader_index_to_type(GLuint i)
> -{
> -   static const GLenum enums[MESA_SHADER_TYPES] = {
> -      GL_VERTEX_SHADER,
> -      GL_GEOMETRY_SHADER,
> -      GL_FRAGMENT_SHADER
> -   };
> -   if (i >= MESA_SHADER_TYPES)
> -      return 0;
> -   else
> -      return enums[i];
> -}
> -
> -
>   #ifdef __cplusplus
>   }
>   #endif
>

For 1, 3, 4, 5:  Reviewed-by: Brian Paul <brianp at vmware.com>

Just had a small question on patch 2, but looks OK otherwise.

-Brian



More information about the mesa-dev mailing list