[Mesa-dev] [PATCH 1/1] mesa: Add some convention to MESA_FORMATs with attention to PIPE_FORMATs

Brian Paul brianp at vmware.com
Thu Dec 19 08:31:21 PST 2013


On 12/18/2013 09:44 PM, Mark Mueller wrote:
> Though a large patch, this is simply a series of global search
> and replace operations. Please refer to formats.h for the core
> deltas. In summary this change adds UNORM, and UINT to formats
> where no type is given, as necessary; replaces the SIGNED designation
> inside the named format with an appened SNORM qualifier; and replaces
> *_INT with *_SINT, thus making MESA_FORMATs more consistent
> with PIPE_FORMATs. This is the first and most intrusive change
> in a crusade to clean up and conventionalize MESA_FORMATs to
> meet needs of contemporary drivers.
>
> No regressions were observed with piglit testing on i965.
> There were no build regressions on gallium ilo, nouveau, r300,
> or r600 after the change.
>
> Signed-off-by: Mark Mueller <MarkKMueller at gmail.com>

Looks good to me, but it would be good to get a second reviewer.

Compiled and seems to run fine here.

Reviewed-by: Brian Paul <brianp at vmware.com>



More information about the mesa-dev mailing list