[Mesa-dev] [PATCH] Use line number information from entire function expression

[Ian Romanick]

On 12/09/2013 12:38 AM, Kevin Rogovin wrote:
> This patch changes the error reporting behavior for incorrect
> function invocation (triggered by match_function_by_name() 
> unable to find a matching function call) from using the line
> number information associated to the function name term
> to using the line number information of the entire function
> expression. Fixes bug #72264.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=72264

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

I'm pushed this patch and tagged it for the 10.0 branch.

> ---
>  src/glsl/ast_function.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/glsl/ast_function.cpp b/src/glsl/ast_function.cpp
> index 6423759..9dc5427 100644
> --- a/src/glsl/ast_function.cpp
> +++ b/src/glsl/ast_function.cpp
> @@ -1656,7 +1656,7 @@ ast_function_expression::hir(exec_list *instructions,
>     } else {
>        const ast_expression *id = subexpressions[0];
>        const char *func_name = id->primary_expression.identifier;
> -      YYLTYPE loc = id->get_location();
> +      YYLTYPE loc = get_location();
>        exec_list actual_parameters;
>  
>        process_parameters(instructions, &actual_parameters, &this->expressions,
>