[Mesa-dev] [PATCH 01/42] i965/fs: generate fs programs also without any 8-width instructions

[Matt Turner]

On Fri, Dec 20, 2013 at 6:38 AM, Topi Pohjolainen
<topi.pohjolainen at intel.com> wrote:
> Signed-off-by: Topi Pohjolainen <topi.pohjolainen at intel.com>
> ---
>  src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp b/src/mesa/drivers/dri/i965/brw_fs_generator.cpp
> index 0cc574c..2381fb0 100644
> --- a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_fs_generator.cpp
> @@ -1809,8 +1809,12 @@ fs_generator::generate_assembly(exec_list *simd8_instructions,
>                                  exec_list *simd16_instructions,
>                                  unsigned *assembly_size)
>  {
> -   dispatch_width = 8;
> -   generate_code(simd8_instructions);
> +   assert(simd8_instructions || simd16_instructions);
> +
> +   if (simd8_instructions) {
> +      dispatch_width = 8;
> +      generate_code(simd8_instructions);
> +   }
>
>     if (simd16_instructions) {
>        /* We have to do a compaction pass now, or the one at the end of
> --
> 1.8.3.1

Thinking out loud (not something you need to do): it would be nice to
have an INTEL_DEBUG=no8 option after this patch lands.