[Mesa-dev] [PATCH 1/7] i965: Include brw_reg.h in brw_disasm.c.

[Kenneth Graunke]

On 12/19/2013 12:48 PM, Eric Anholt wrote:
> Kenneth Graunke <kenneth at whitecape.org> writes:
> 
>> We're going to move some things from brw_defines.h there in a moment.
>> Both files contain symbols named negate, so we need to arbitrarily
>> rename them.  (The "m_" prefix is a convention I adopted in the Gen8+
>> code).
> 
> I think maybe series rewrites may have made this patch unnecessary?  The
> uses of BRW_REGISTER_TYPE_* by the end I think have all been rewritten
> to use the HW_REG_TYPE that are still in brw_defines.h.
> 
> Other than that, this series is:
> 
> Reviewed-by: Eric Anholt <eric at anholt.net>

Good catch!  I originally didn't have the HW_REG_TYPE values, but then
all the magic constants in brw_disasm and gen8_disasm made me sad.

I've dropped patch 1, as it doesn't appear necessary.  Thanks for the
review.