[Mesa-dev] [PATCH 1/2] radeonsi: Write zero to DB_RENDER_OVERRIDE. This register does nothing.

[Marek Olšák]

I probably wasn't clear enough. HiS was not enabled. Only stencil
compression was (judging from the fact we have to use depth-stencil
decompression before texturing, see r600_blit.c).

Sorry, I won't accept this patch, because I don't know how HiS works (yet).

Marek

On Sat, Dec 21, 2013 at 9:11 PM, Andreas Hartmetz <ahartmetz at gmail.com> wrote:
> This is not officially documented, but Marek says it is so.
> It also means that HiS was already enabled, we just didn't know it.
> ---
>  src/gallium/drivers/radeonsi/si_state.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c
> index 8705d16..d7d8317 100644
> --- a/src/gallium/drivers/radeonsi/si_state.c
> +++ b/src/gallium/drivers/radeonsi/si_state.c
> @@ -3193,9 +3193,7 @@ void si_init_config(struct r600_context *rctx)
>         si_pm4_set_reg(pm4, R_028AC0_DB_SRESULTS_COMPARE_STATE0, 0x0);
>         si_pm4_set_reg(pm4, R_028AC4_DB_SRESULTS_COMPARE_STATE1, 0x0);
>         si_pm4_set_reg(pm4, R_028AC8_DB_PRELOAD_CONTROL, 0x0);
> -       si_pm4_set_reg(pm4, R_02800C_DB_RENDER_OVERRIDE,
> -                      S_02800C_FORCE_HIS_ENABLE0(V_02800C_FORCE_DISABLE) |
> -                      S_02800C_FORCE_HIS_ENABLE1(V_02800C_FORCE_DISABLE));
> +       si_pm4_set_reg(pm4, R_02800C_DB_RENDER_OVERRIDE, 0);
>         si_pm4_set_reg(pm4, R_028400_VGT_MAX_VTX_INDX, ~0);
>         si_pm4_set_reg(pm4, R_028404_VGT_MIN_VTX_INDX, 0);
>
> --
> 1.8.3.2
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev