[Mesa-dev] [PATCH 1/1] Adjust MESA_FORMAT color component ordering to match API docs

[Michel Dänzer]

On Fre, 2013-12-20 at 12:28 -0800, Mark Mueller wrote:

>         Also, because these Mesa formats are defined as packed values,
>         you're
>         essentially changing the notation from big endian (aka human
>         readable)
>         to little endian. It's unfortunate that the packed
>         PIPE_FORMATs are
>         named in little endian order, that's a concession we had to
>         make when
>         adding them.
> 
> 
> Are they all really big endian, currently it looks like a mix of who
> knows what.

The formats defined as packed values use big endian notation. Don't
confuse them with formats which are not defined as packed values.


>         > Remove comments giving MESA_FORMAT color packings, some of
>         which are
>         > misleading.
>         
>         
>         Which ones are misleading, and how?
> 
> 
> Bottom line, if the MESA_FORMATs follow the API's convention, then the
> reader can go to the API for clarification and we don't have to
> maintain that in the code.

Then replace the comments with specific references to which API format
describes each Mesa format, don't just remove them.


-- 
Earthling Michel Dänzer            |                  http://www.amd.com
Libre software enthusiast          |                Mesa and X developer